fix: untangle macOS release notarization#123
Merged
ibourgeois merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the tagged macOS release workflow to prevent NativePHP/Electron’s afterSign hook from notarizing during the build, and instead performs app notarization explicitly in the workflow before stapling—making artifact discovery and failure diagnostics more reliable.
Changes:
- Add a workflow-level flag to skip NativePHP’s built-in
afterSignnotarization and patch the upstream hook at runtime. - Make DMG discovery more resilient and print directory contents when expected artifacts aren’t found.
- Explicitly archive and notarize the
.appbundle in the workflow prior to stapling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122.
Summary
afterSignhook from notarizing during the build jobVerification
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/tagged-release.yml")'